Merge pull request #208 from Solvik/fix/chriss/virtual_network_nic_mac_addr

Fixed virtual network cards creation
This commit is contained in:
Christophe Simon 2022-03-08 17:31:26 +01:00 committed by GitHub
commit b53dfa9b59
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -261,7 +261,7 @@ class Network(object):
def create_netbox_nic(self, nic, mgmt=False): def create_netbox_nic(self, nic, mgmt=False):
# TODO: add Optic Vendor, PN and Serial # TODO: add Optic Vendor, PN and Serial
type = self.get_netbox_type_for_nic(nic) nic_type = self.get_netbox_type_for_nic(nic)
logging.info('Creating NIC {name} ({mac}) on {device}'.format( logging.info('Creating NIC {name} ({mac}) on {device}'.format(
name=nic['name'], mac=nic['mac'], device=self.device.name)) name=nic['name'], mac=nic['mac'], device=self.device.name))
@ -270,11 +270,10 @@ class Network(object):
params = dict(self.custom_arg) params = dict(self.custom_arg)
params.update({ params.update({
'name': nic['name'], 'name': nic['name'],
'type': type, 'type': nic_type,
'mgmt_only': mgmt, 'mgmt_only': mgmt,
}) })
if nic['mac']:
if not nic.get('virtual', False):
params['mac_address'] = nic['mac'] params['mac_address'] = nic['mac']
interface = self.nb_net.interfaces.create(**params) interface = self.nb_net.interfaces.create(**params)