Hosterra/netbox-agent
Hosterra/netbox-agent
1
0
Fork 0
Code Issues Pull requests Activity

Fix inventory crash on nvme binary too old or absent (#170)

Browse source 
* When nvme binary absent or too old and no json output, this crash the inventory, i prefer just pass nvme inventory and continue

* log if nvme-cli is not installed
This commit is contained in:
Cyrinux 2020-10-14 12:40:19 +02:00 • committed by GitHub
commit 0f2cb531ae
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 22 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

6
netbox_agent/lshw.py
View file

@ -88,6 +88,10 @@ class LSHW():
self.disks.append(d) self.disks.append(d)
elif "nvme" in obj["configuration"]["driver"]: elif "nvme" in obj["configuration"]["driver"]:
if not is_tool('nvme'):
logging.error('nvme-cli >= 1.0 does not seem to be installed')
else:
try:
nvme = json.loads( nvme = json.loads(
subprocess.check_output( subprocess.check_output(
["nvme", '-list', '-o', 'json'], ["nvme", '-list', '-o', 'json'],
@ -104,6 +108,8 @@ class LSHW():
d['description'] = "NVME Disk" d['description'] = "NVME Disk"
self.disks.append(d) self.disks.append(d)
except Exception:
pass
def find_cpus(self, obj): def find_cpus(self, obj):
if "product" in obj: if "product" in obj: