Extract general QueryBuilder logic into an abstract class to make it more maintainable

Signed-off-by: davidarendsen <davidarendsen@hey.com>
This commit is contained in:
davidarendsen 2022-12-21 16:02:43 +00:00
commit df6ff71375
5 changed files with 218 additions and 176 deletions

View file

@ -0,0 +1,161 @@
<?php
namespace Arendsen\FluxQueryBuilder\Builder;
use DateTime;
use Exception;
use Arendsen\FluxQueryBuilder\Builder\FluxPart;
use Arendsen\FluxQueryBuilder\Expression\KeyValue;
use Arendsen\FluxQueryBuilder\Expression\KeyFilter;
use Arendsen\FluxQueryBuilder\Functions\AggregateWindow;
use Arendsen\FluxQueryBuilder\Functions\Duplicate;
use Arendsen\FluxQueryBuilder\Functions\Filter;
use Arendsen\FluxQueryBuilder\Functions\From;
use Arendsen\FluxQueryBuilder\Functions\Range;
use Arendsen\FluxQueryBuilder\Functions\Reduce;
use Arendsen\FluxQueryBuilder\Functions\Sort;
use Arendsen\FluxQueryBuilder\Functions\Map;
use Arendsen\FluxQueryBuilder\Functions\Group;
use Arendsen\FluxQueryBuilder\Functions\Limit;
use Arendsen\FluxQueryBuilder\Functions\Mean;
use Arendsen\FluxQueryBuilder\Functions\RawFunction;
use Arendsen\FluxQueryBuilder\Functions\Window;
abstract class AbstractQueryBuilder
{
public const REQUIRED_INPUT_FROM = 'from';
public const REQUIRED_INPUT_RANGE = 'range';
public const REQUIRED_INPUT_MEASUREMENT = 'measurement';
public const REQUIRED_INPUT = [
self::REQUIRED_INPUT_FROM,
self::REQUIRED_INPUT_RANGE,
self::REQUIRED_INPUT_MEASUREMENT,
];
/**
* @var int $currentFluxQueryPart
*/
private $currentFluxQueryPart = 0;
/**
* @var array $fluxQuery
*/
private $fluxQueryParts = [];
/**
* @var array $requiredData
*/
private $requiredData = [];
public function from(array $from): AbstractQueryBuilder
{
$this->addRequiredData(self::REQUIRED_INPUT_FROM, $from);
$this->addToQuery(
FluxPart::FROM,
new From($from)
);
return $this;
}
public function fromBucket(string $bucket): AbstractQueryBuilder
{
$this->from(['bucket' => $bucket]);
return $this;
}
public function fromMeasurement(string $measurement): AbstractQueryBuilder
{
$this->addRequiredData(self::REQUIRED_INPUT_MEASUREMENT, $measurement);
$this->addKeyFilter(KeyFilter::setEqualTo('_measurement', $measurement));
return $this;
}
/**
* @deprecated
*
* @param KeyValue $keyValue
* @return QueryBuilder
*/
public function addFilter(KeyValue $keyValue): AbstractQueryBuilder
{
$this->addToQuery(
FluxPart::FILTERS,
new Filter($keyValue)
);
return $this;
}
public function addKeyFilter(KeyFilter $keyFilter): AbstractQueryBuilder
{
$this->addToQuery(
FluxPart::FILTERS,
new Filter($keyFilter)
);
return $this;
}
public function addFieldFilter(array $fields): AbstractQueryBuilder
{
$this->addToQuery(
FluxPart::FILTERS,
new Filter($fields)
);
return $this;
}
public function addRange(DateTime $start, ?DateTime $stop = null): AbstractQueryBuilder
{
$this->addRequiredData(self::REQUIRED_INPUT_RANGE, [$start, $stop]);
$this->addToQuery(
FluxPart::RANGE,
new Range($start, $stop)
);
return $this;
}
public function addRangeStart(DateTime $start): AbstractQueryBuilder
{
$this->addRange($start);
return $this;
}
public function addRangeInBetween(DateTime $start, DateTime $stop)
{
$this->addRange($start, $stop);
return $this;
}
protected function addToQuery($key, $query)
{
$this->fluxQueryParts[$this->currentFluxQueryPart] = $query;
$this->currentFluxQueryPart++;
}
public function build(): string
{
$this->checkRequired();
$query = '';
foreach ($this->fluxQueryParts as $part) {
$query .= $part;
}
return $query;
}
protected function addRequiredData(string $key, $value)
{
$this->requiredData[][$key] = $value;
}
protected function checkRequired()
{
foreach (self::REQUIRED_INPUT as $key => $input) {
if (!isset($this->requiredData[$key][$input])) {
throw new Exception('You need to define the "' . $input . '" part of the query!');
}
}
}
}

21
src/Builder/FluxPart.php Normal file
View file

@ -0,0 +1,21 @@
<?php
namespace Arendsen\FluxQueryBuilder\Builder;
class FluxPart
{
public const FROM = 'from';
public const RANGE = 'range';
public const FILTERS = 'filters';
public const REDUCE = 'reduce';
public const MAP = 'map';
public const SORT = 'sort';
public const GROUP = 'group';
public const LIMIT = 'limit';
public const WINDOW = 'window';
public const MEAN = 'mean';
public const DUPLICATE = 'duplicate';
public const UNWINDOW = 'unwindow';
public const AGGREGATEWINDOW = 'aggregateWindow';
public const RAWFUNCTION = 'raw';
}